Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1123) PR mergeμ‹œ μ—°κ΄€ 이슈 μžλ™ closeκ°€ λ™μž‘ν•˜μ§€ μ•ŠλŠ” 이슈 #1124

Merged
merged 2 commits into from
Aug 14, 2024
Merged

πŸ”€ :: (#1123) PR mergeμ‹œ μ—°κ΄€ 이슈 μžλ™ closeκ°€ λ™μž‘ν•˜μ§€ μ•ŠλŠ” 이슈 #1124

merged 2 commits into from
Aug 14, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

PR mergeμ‹œ μ—°κ΄€ 이슈 μžλ™ closeκ°€ λ™μž‘ν•˜μ§€ μ•ŠλŠ” 이슈

Resolves: #1123

πŸ“ƒ μž‘μ—…λ‚΄μš©

PR mergeμ‹œ μ—°κ΄€ 이슈 μžλ™ closeκ°€ λ™μž‘ν•˜μ§€ μ•ŠλŠ” 이슈

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@baekteun baekteun linked an issue Aug 14, 2024 that may be closed by this pull request
PR mergeμ‹œ μ—°κ΄€ 이슈 μžλ™ closeκ°€ λ™μž‘ν•˜μ§€ μ•ŠλŠ” 이슈 #1123
Closed
@github-actions github-actions bot added 3️⃣ Priority: Low μš°μ„ μˆœμœ„ ν•˜ βš™ Setting 개발 ν™˜κ²½ μ„ΈνŒ… labels Aug 14, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

@baekteun baekteun merged commit 70ed118 into develop Aug 14, 2024
2 checks passed
@baekteun baekteun deleted the 1123-pr-merge-associated-issue-close branch August 14, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
3️⃣ Priority: Low μš°μ„ μˆœμœ„ ν•˜ βš™ Setting 개발 ν™˜κ²½ μ„ΈνŒ…
Projects
None yet
Milestone
No milestone
2 participants
@baekteun @yongbeomkwak