Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#1131) ๋งˆ์ดํŽ˜์ด์ง€ ์—ด๋งค ๋ฒ„ํŠผ ๋ฐฐ๊ฒฝ์ƒ‰ ๋ณ€๊ฒฝ #1133

Merged
merged 1 commit into from
Aug 14, 2024
Merged

๐Ÿ”€ :: (#1131) ๋งˆ์ดํŽ˜์ด์ง€ ์—ด๋งค ๋ฒ„ํŠผ ๋ฐฐ๊ฒฝ์ƒ‰ ๋ณ€๊ฒฝ #1133

merged 1 commit into from
Aug 14, 2024

Conversation

baekteun
Copy link
Member

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋งˆ์ดํŽ˜์ด์ง€ ์—ด๋งค ๋ฒ„ํŠผ ๋ฐฐ๊ฒฝ์ƒ‰ ๋ณ€๊ฒฝ

  • white -> white.alpha(0.4)

Resolves: #1131

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๋งˆ์ดํŽ˜์ด์ง€ ์—ด๋งค ๋ฒ„ํŠผ ๋ฐฐ๊ฒฝ์ƒ‰ ๋ณ€๊ฒฝ

  • white -> white.alpha(0.4)

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ labels Aug 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun

@baekteun baekteun merged commit 72ab462 into release/3.0.0 Aug 14, 2024
5 checks passed
@baekteun baekteun deleted the 1131-my-info-page-fruit-button-background-color branch August 14, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@youn9k youn9k youn9k approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

Assignees

@baekteun baekteun

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baekteun @yongbeomkwak @youn9k