Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1135) ν¬λ ˆλ”§ μž‘μ—…μž ν”„λ‘œν•„ 이미지 지원 #1136

Merged
merged 1 commit into from
Aug 14, 2024
Merged

πŸ”€ :: (#1135) ν¬λ ˆλ”§ μž‘μ—…μž ν”„λ‘œν•„ 이미지 지원 #1136

merged 1 commit into from
Aug 14, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

  • ν¬λ ˆλ”§ μž‘μ—…μžμ˜ ν”„λ‘œν•„ 이미지λ₯Ό μ§€μ›ν•΄μš”.

Resolves: #1135

πŸ“ƒ μž‘μ—…λ‚΄μš©

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ✨ Feature 피쳐 개발 labels Aug 14, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun baekteun force-pushed the 1135-add-credit-profile-image branch from 473434c to ffadfd2 Compare August 14, 2024 14:45
@baekteun baekteun merged commit b0ca385 into release/3.0.0 Aug 14, 2024
3 checks passed
@baekteun baekteun deleted the 1135-add-credit-profile-image branch August 14, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ✨ Feature 피쳐 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baekteun @yongbeomkwak