Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1158) μ•„ν‹°μŠ€νŠΈ 선택이 μ•ˆλ¨ 2t #1159

Merged
merged 1 commit into from
Aug 15, 2024
Merged

πŸ”€ :: (#1158) μ•„ν‹°μŠ€νŠΈ 선택이 μ•ˆλ¨ 2t #1159

merged 1 commit into from
Aug 15, 2024

Conversation

KangTaeHoon
Copy link
Contributor

πŸ’‘ λ°°κ²½ 및 κ°œμš”

  • μ•„ν‹°μŠ€νŠΈ 선택이 μ•ˆλ¨ 2t

Resolves: #1158

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • 델리게이트 채택 제거

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

x

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@KangTaeHoon KangTaeHoon changed the base branch from develop to release/3.0.0 August 15, 2024 17:09
@github-actions github-actions bot added the 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ label Aug 15, 2024
@github-actions github-actions bot added the 🐞 Bug 버그 κ΄€λ ¨ label Aug 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

baekteun
baekteun approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ˜”

@KangTaeHoon KangTaeHoon merged commit cae7d84 into release/3.0.0 Aug 15, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the 1158-bug-fix-artist-tap branch August 15, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

@yongbeomkwak yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ 🐞 Bug 버그 κ΄€λ ¨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

μ•„ν‹°μŠ€νŠΈ 선택이 μ•ˆλ˜λŠ” 이슈 2t
2 participants
@KangTaeHoon @baekteun