-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ :: (#1109) ์๋ฎค ์ถ์ฒ ํ๋ฆฌ ํค๋ ๋ฒํผ์ ์ ์ฒด ์ฌ์์ผ๋ก ํต์ผ #1202
Merged
yongbeomkwak
merged 9 commits into
release/3.0.0
from
1109-replace-wakmusic-playlist-button-header
Aug 20, 2024
+160
โ62
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c3b5f6f
:zap: :: 50๊ณก ์ด๊ณผ ์ฒ๋ฆฌ
yongbeomkwak 305403a
๐จ :: ์ฝ๋ Formatting ์ ์ฉ
yongbeomkwak 2919a98
:zap: :: ์ํฐํฐ DTO ์์ฑ
yongbeomkwak 6c4d993
:zap: :: ์ ์ฆ ์ผ์ด์ค ์์ฑ ํ ์ฐ๊ฒฐ
yongbeomkwak 30fd9b0
:zap: :: ์๋ฎค ํ๋ฆฌ url๋ก ์ด๊ธฐ
yongbeomkwak 8356301
๐จ :: ์ฝ๋ Formatting ์ ์ฉ
yongbeomkwak 32edda5
Merge branch 'release/3.0.0' into 1109-replace-wakmusic-playlist-buttโฆ
yongbeomkwak 4ababc8
:fire: :: ์ปจํ๋ฆญํธ ํด๊ฒฐ ์ค ์ค๋ณต์ฝ๋ ์ ๊ฑฐ
yongbeomkwak a4ef646
๐จ :: ์ฝ๋ Formatting ์ ์ฉ
yongbeomkwak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
Projects/Domains/PlaylistDomain/Interface/Entity/WmPlaylistDetailEntity.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import Foundation | ||
import SongsDomainInterface | ||
|
||
public struct WmPlaylistDetailEntity: Equatable { | ||
public init( | ||
key: String, | ||
title: String, | ||
songs: [SongEntity], | ||
image: String, | ||
playlistURL: String | ||
) { | ||
self.key = key | ||
self.title = title | ||
self.songs = songs | ||
self.image = image | ||
self.playlistURL = playlistURL | ||
} | ||
|
||
public let key, title, image, playlistURL: String | ||
public var songs: [SongEntity] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
Projects/Domains/PlaylistDomain/Interface/UseCase/FetchWmPlaylistDetailUseCase.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import Foundation | ||
import RxSwift | ||
|
||
public protocol FetchWmPlaylistDetailUseCase { | ||
func execute(id: String) -> Single<WmPlaylistDetailEntity> | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
Projects/Domains/PlaylistDomain/Sources/ResponseDTO/WmPlaylistDetailResponseDTO.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import Foundation | ||
import PlaylistDomainInterface | ||
import SongsDomain | ||
import SongsDomainInterface | ||
|
||
public struct WmPlaylistDetailResponseDTO: Decodable { | ||
public let key: String? | ||
public let title: String | ||
public let songs: [SingleSongResponseDTO]? | ||
public let imageURL: String | ||
public let playlistURL: String | ||
|
||
enum CodingKeys: String, CodingKey { | ||
case key | ||
case title | ||
case songs | ||
case imageURL = "imageUrl" | ||
case playlistURL = "playlistUrl" | ||
} | ||
} | ||
|
||
public extension WmPlaylistDetailResponseDTO { | ||
func toDomain() -> WmPlaylistDetailEntity { | ||
WmPlaylistDetailEntity( | ||
key: key ?? "", | ||
title: title, | ||
songs: (songs ?? []).map { $0.toDomain() }, | ||
image: imageURL, | ||
playlistURL: playlistURL | ||
) | ||
} | ||
} |
8 changes: 0 additions & 8 deletions
8
Projects/Domains/PlaylistDomain/Sources/UseCase/FetchPlaylistDetailUseCaseImpl.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
Projects/Domains/PlaylistDomain/Sources/UseCase/FetchWmPlaylistDetailUseCaseImpl.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import Foundation | ||
import PlaylistDomainInterface | ||
import RxSwift | ||
|
||
public struct FetchWmPlaylistDetailUseCaseImpl: FetchWmPlaylistDetailUseCase { | ||
private let playlistRepository: any PlaylistRepository | ||
|
||
public init( | ||
playlistRepository: PlaylistRepository | ||
) { | ||
self.playlistRepository = playlistRepository | ||
} | ||
|
||
public func execute(id: String) -> Single<WmPlaylistDetailEntity> { | ||
playlistRepository.fetchWmPlaylistDetail(id: id) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wm๋ณด๋ค๋ WM์ผ๋ก ํ๋๊ฒ ์คํ์ผ ๊ฐ์ด๋์์ผ๋ก ์ ์๋์ด์์ด์.
https://www.notion.so/waktaverse/Swift-Style-Guide-f87a0e12cb7742d69548fdd7b695c302?pvs=4#5295e1f460f34bac994e1cfc1929e358
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ๋ ์ ๋ฐ๊ฟ ๋๊ฒ ์ต๋๋ค!