Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#1200) ์žฌ์ƒ ํ”Œ๋žซํผ์— ์œ ํŠœ๋ธŒ ๋ฎค์ง ์ง€์› #1236

Merged
merged 1 commit into from
Aug 26, 2024
Merged

๐Ÿ”€ :: (#1200) ์žฌ์ƒ ํ”Œ๋žซํผ์— ์œ ํŠœ๋ธŒ ๋ฎค์ง ์ง€์› #1236

merged 1 commit into from
Aug 26, 2024

Conversation

baekteun
Copy link
Member

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์žฌ์ƒ ํ”Œ๋žซํผ์— ์œ ํŠœ๋ธŒ ๋ฎค์ง ์ง€์›

  • ์žฌ์ƒ ํ”Œ๋žซํผ์— ์œ ํŠœ๋ธŒ ๋ฎค์ง ์ง€์›

Resolves: #1200

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ์žฌ์ƒ ํ”Œ๋žซํผ์— ์œ ํŠœ๋ธŒ ๋ฎค์ง ์ง€์›

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

PreferenseManager๋ฅผ Player๊ฐ€ ์ฐธ์กฐํ•˜๋Š”๊ฒŒ ์‚ด์ง ์ข€ ๋งˆ์Œ์— ๊ฑธ๋ฆฌ์ง€๋งŒ ํฐ ๋ฌธ์ œ๋Š” ์—†๋‹ค๊ณ  ํŒ๋‹จํ•ด์„œ ์šฐ์„  ์ง„ํ–‰ํ–ˆ์–ด์š”.

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ labels Aug 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun

@baekteun baekteun force-pushed the 1200-support-youtube-music-open branch from 4677790 to 707c697 Compare August 26, 2024 13:18
@baekteun baekteun merged commit 4e0a0b4 into release/3.0.0 Aug 26, 2024
3 checks passed
@baekteun baekteun deleted the 1200-support-youtube-music-open branch August 26, 2024 15:19
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak Awaiting requested review from yongbeomkwak yongbeomkwak is a code owner

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baekteun @KangTaeHoon