Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#1245) SingleAction ๋ฒ„ํŠผ Blur ์ ์šฉ #1246

Merged
merged 2 commits into from
Aug 28, 2024
Merged

๐Ÿ”€ :: (#1245) SingleAction ๋ฒ„ํŠผ Blur ์ ์šฉ #1246

merged 2 commits into from
Aug 28, 2024

Conversation

yongbeomkwak
Copy link
Member

@yongbeomkwak yongbeomkwak commented Aug 28, 2024 •
edited by youn9k
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

  • ์ตœ์‹ ์Œ์•… , ์™๋ฎค ์ถ”์ฒœ ํ”Œ๋ฆฌ ํ—ค๋” ๋ฒ„ํŠผ ๋ธ”๋Ÿฌ ์ ์šฉ ์š”์ฒญ

Resolves: #1245

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

visual Effect View regular๋กœ ์ ์šฉ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ labels Aug 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@yongbeomkwak

@yongbeomkwak yongbeomkwak merged commit d9105f6 into release/3.0.0 Aug 28, 2024
5 checks passed
@yongbeomkwak yongbeomkwak deleted the 1245-apply-glass-effect-on-wak-music-playlist branch August 28, 2024 06:01
@github-actions github-actions bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youn9k youn9k youn9k approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@yongbeomkwak yongbeomkwak

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yongbeomkwak @youn9k