fix: lite-protocol-tester receiver exit check #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded a timely check from the last arrived message
…veal service nodes origins
NagyZoltanPeter
requested review from
darshankabariya,
gabrielmer and
Ivansete-status
|
You can find the image built from this PR at Built from d8614b7 |
gabrielmer
reviewed
Nov 29, 2024
gabrielmer
approved these changes
Nov 29, 2024
Ivansete-status
approved these changes
Dec 5, 2024
…ional Moment instead of result - better explains what is happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After deployment liteprotocoltester into infra and see running for some days it turned out that in some cases receiver side cannot detect end of test and keeps waiting for more messages.
This PR fixes it with introducing a max time after last message arrived to consider exiting from test loop.
Also valuable information is added to logging and metrics, tested peers and service node failures now distinguished by agent string also. This way dashboard and provide information of node types and versions of erroneous peers.