feat: connection change event #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 7e542ae |
gabrielmer
requested review from
richard-ramos,
Ivansete-status,
darshankabariya and
NagyZoltanPeter
Ivansete-status
approved these changes
Jan 3, 2025
gabrielmer
force-pushed
the
feat-connection-change-event
branch
from
9df578a to
5e46781
Compare
richard-ramos
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a connection health change event which gets triggered every time a peer connects or disconnects. When the event is triggered, a new app callback named
connectionChangeHandleris called. This PR also integrates the event to libwaku.Changes
eventCallbacktemplate in libwaku to avoid code duplicationIssue
#3076