fix: libwaku's invalid waku message error handling #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmer
requested review from
richard-ramos,
darshankabariya,
NagyZoltanPeter and
Ivansete-status
|
You can find the image built from this PR at Built from 7a3d2f2 |
| @@ -297,7 +297,6 @@ proc waku_relay_publish( | |||
| jsonMessage = JsonMessage.fromJsonNode(jsonContent).valueOr: | |||
| raise newException(JsonParsingError, $error) | |||
| except JsonParsingError: | |||
| deallocShared(jwm) | |||
There was a problem hiding this comment.
Is jwm deallocated on finally, even if we have the return on line 302?
There was a problem hiding this comment.
Good question. I think it should.
Nevertheless, @gabrielmer I think it is safer to use the defer approach in this case too.
There was a problem hiding this comment.
My understanding is that yes, but agree - let's use defer :)
richard-ramos
approved these changes
Feb 17, 2025
Ivansete-status
approved these changes
Feb 17, 2025
| @@ -297,7 +297,6 @@ proc waku_relay_publish( | |||
| jsonMessage = JsonMessage.fromJsonNode(jsonContent).valueOr: | |||
| raise newException(JsonParsingError, $error) | |||
| except JsonParsingError: | |||
| deallocShared(jwm) | |||
There was a problem hiding this comment.
Good question. I think it should.
Nevertheless, @gabrielmer I think it is safer to use the defer approach in this case too.
gabrielmer
deleted the
chore-libwaku-handling-gracefully-invalid-message-formats
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking if required
WakuMessagefields exist before trying to access them and returning an error in case they are not present in the message.Additionally, fixing double dealloc in case of failure.
Changes
Issue