fix: subscribing to RelaydefaultHandler in libwaku #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmer
requested review from
Ivansete-status,
richard-ramos and
NagyZoltanPeter
and removed request for
Ivansete-status and
richard-ramos
NagyZoltanPeter
approved these changes
Feb 26, 2025
|
You can find the image built from this PR at Built from 9edb95d |
Ivansete-status
approved these changes
Feb 26, 2025
gabrielmer
deleted the
fix-store-for-in-libwaku-for-dynamically-subscribed-shards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In libwaku nodes, messages aren't being saved in Store for dynamically-subscribed shards. This happens because when subscribing dynamically via libwaku, we weren't setting the
defaultRelayHandlerwe rely on for Store and other protocols.We need to subscribe to the default handler when dynamically subscribing to topics too.
Changes
registerRelayDefaultHandlerwhen callingwaku_relay_subscribein libwakuIssue
#3076