Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add simple Qt example that uses libwaku #3310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ivansete-status
Copy link
Collaborator

Description

Simple Qt example that runs libwaku.
It only contains two buttons: start node; stop node.

image

note: This is part of investigation where we see that Status app crashes when loading libwaku.

Issue

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. LGTM!

void* userData = nullptr;

char jsonConfig[5000];
snprintf(jsonConfig, 5000, "{ \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, but you don't need sprintf if this is only static string...or bet you can directly use QString here.

public:
WakuHandler() : QObject(), ctx(nullptr) {}

void initialize(const QString& jsonConfig, void* event_handler, void* userData) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think void* event_handler can directly be WakuCallBack type...

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazinggg, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants