-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add simple Qt example that uses libwaku #3310
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking. LGTM!
void* userData = nullptr; | ||
|
||
char jsonConfig[5000]; | ||
snprintf(jsonConfig, 5000, "{ \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, but you don't need sprintf if this is only static string...or bet you can directly use QString here.
public: | ||
WakuHandler() : QObject(), ctx(nullptr) {} | ||
|
||
void initialize(const QString& jsonConfig, void* event_handler, void* userData) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think void* event_handler can directly be WakuCallBack type...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazinggg, thanks so much!
Description
Simple Qt example that runs libwaku.
It only contains two buttons: start node; stop node.
note: This is part of investigation where we see that Status app crashes when loading libwaku.
Issue