Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry: Global search #1043

Merged
merged 12 commits into from
Feb 19, 2025
Merged

Registry: Global search #1043

merged 12 commits into from
Feb 19, 2025

Conversation

ngrayluna
Copy link
Contributor

@ngrayluna ngrayluna commented Jan 28, 2025

Adds doc on how to globally search for artifact versions, collections, collection tags, or registry.

Ready for tech review. Will ping Docs Team (i.e. Matt) for review when tech review is done or near complete.

Confirm that tests pass and this change is ready for review:

  • Local hugo serve
  • [] Local vale ./content

Copy link

cloudflare-workers-and-pages bot commented Jan 28, 2025

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 06c377d
Status: ✅  Deploy successful!
Preview URL: https://234d13be.docodile.pages.dev
Branch Preview URL: https://registry-search-global.docodile.pages.dev

View logs

@ngrayluna ngrayluna marked this pull request as ready for review February 6, 2025 17:34
@ngrayluna ngrayluna requested a review from a team as a code owner February 6, 2025 17:34
@ngrayluna
Copy link
Contributor Author

Ready for tech review.

ngrayluna and others added 2 commits February 6, 2025 09:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some suggestions to help this content stand on its own a bit more. WDYT?

@ngrayluna ngrayluna requested a review from noaleetz February 10, 2025 16:35
Copy link
Contributor

@noaleetz noaleetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add Amulya as well as a reviewer just to get a stamp from eng as well!

@ngrayluna ngrayluna requested a review from noaleetz February 19, 2025 18:48
Copy link
Contributor

@amusipatla-wandb amusipatla-wandb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Noah!

@ngrayluna ngrayluna merged commit 15f9f62 into main Feb 19, 2025
6 checks passed
@ngrayluna ngrayluna deleted the registry_search_global branch February 19, 2025 19:23
@ngrayluna
Copy link
Contributor Author

Approved by Eng and Doc Writer. Merging w/out secound approval from Noa. S because a) I incorporated their feedback into this PR, b) the feature shipped today, and c) Noa S. is out today (2/19)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants