-
Notifications
You must be signed in to change notification settings - Fork 27
[DOCS-1166][DOCS-880][DOCS-1167][DOCS-1168] Update automation docs #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying docs with
|
Latest commit: |
803b7e2
|
Status: | ✅ Deploy successful! |
Preview URL: | https://6e710725.docodile.pages.dev |
Branch Preview URL: | https://automation-updates.docodile.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments!
When we do add the docs for run metric events, they need a lot more explanation of how they work than what we have here - we should definitely meet at that time to walk through it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partway through but have to step away, so wanted to leave any comments I have so far --
Co-authored-by: Stephen Sisk <[email protected]>
Captured for fast follow |
Co-authored-by: Noa <[email protected]>
The example payloads are not missing, we discussed offline. The other have been captured to https://wandb.atlassian.net/browse/DOCS-1379 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already approved but contains additional feedback to address
content/guides/core/secrets.md
Outdated
Specify the secrets you want to use for your webhook automation when you configure the webhook. See the [Configure a webhook]({{< relref "#configure-a-webhook" >}}) section for more information. | ||
|
||
{{% alert %}} | ||
Once you create a secret, you can access that secret in your W&B workflows with `$`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not totally obvious how to use $ to access - I presume prefixing the name with $? Also, "W&B workflows" aren't really a thing - would automations be a more precise terminology?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I don't think I introduced this and I wasn't sure what it meant. Now updated.
content/guides/core/secrets.md
Outdated
1. Read the confirmation dialog, then click **Delete**. The secret is deleted immediately and permanently. | ||
|
||
## Manage access to secrets | ||
Each member of a team have access to its secrets. To revoke access to a secret from a particular member, remove that member from the team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if no one can see the contents of a secret, and only admins can create/edit/delete them, what does it mean for a team member to have access to a secret?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, well a secret is a team-level asset. I guess it means that the team's automations get access to the secret. Let me try again.
From either of these pages, a Registry admin can manage existing automations: | ||
- To view an automation's details, click its name. | ||
- To edit an automation, click its action `...` menu, then click **Edit automation**. | ||
- To delete an automation, click its action `...` menu, then click **Delete automation**. Confiruation is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does "configuration is required" mean here? I think we can get rid of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmation is required. Thanks!
From either of these pages, a Registry admin can manage existing automations: | ||
- To view an automation's details, click its name. | ||
- To edit an automation, click its action `...` menu, then click **Edit automation**. | ||
- To delete an automation, click its action `...` menu, then click **Delete automation**. Confiruation is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmation is required. Thanks!
| `${ACCESS_TOKEN}` | The value of the access token configured in the [webhook integration]({{< relref "#add-a-webhook-integration" >}}), if an access token is configured. The access token is automatically passed in the `Authorization: Bearer` HTTP header. | | ||
| `${<SECRET>}` | If configured, the value of a secret configured in the [webhook integration]({{< relref "#add-a-webhook-integration" >}}). Replace `<SECRET>` with the name of the secret. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssisk These were previously missing.
content/guides/core/secrets.md
Outdated
Specify the secrets you want to use for your webhook automation when you configure the webhook. See the [Configure a webhook]({{< relref "#configure-a-webhook" >}}) section for more information. | ||
|
||
{{% alert %}} | ||
Once you create a secret, you can access that secret in your W&B workflows with `$`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I don't think I introduced this and I wasn't sure what it meant. Now updated.
content/guides/core/secrets.md
Outdated
1. Read the confirmation dialog, then click **Delete**. The secret is deleted immediately and permanently. | ||
|
||
## Manage access to secrets | ||
Each member of a team have access to its secrets. To revoke access to a secret from a particular member, remove that member from the team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, well a secret is a team-level asset. I guess it means that the team's automations get access to the secret. Let me try again.
Co-authored-by: Noa <[email protected]>
- Add missing Webhook and Slack Notification sections to Team Settings - In both User and Team settings, note that wandb.alerts also requires an enterprise license
|
||
This page describes _automations_ in W&B. [Create an automation]({{< relref "create-automations/" >}}) to trigger workflow steps, such as automated model testing and deployment, based on an event in W&B, such as when an [artifact]({{< relref "/guides/core/artifacts" >}}) artifact version is created ({{< relref "/guides/core/registry/" >}}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link incorrectly formatted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
{{< readfile file="/_includes/enterprise-only.md" >}} | ||
{{% /pageinfo %}} | ||
|
||
An automation can run when a specific event occurs at a given scope, either a registry or a project. This page describes the events that can trigger an automation at each scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I try to avoid using "run" if it's not in the context of creating a run. (Unfortunate naming of an object).
|
||
This page describes _automations_ in W&B. [Create an automation]({{< relref "create-automations/" >}}) to trigger workflow steps, such as automated model testing and deployment, based on an event in W&B, such as when an [artifact]({{< relref "/guides/core/artifacts" >}}) artifact version is created ({{< relref "/guides/core/registry/" >}}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Noah Luna <[email protected]>
Update all possible links and references to old Model Registry
Consolidate project-scoped and model registry automations, new Slack notification flow, ability to edit automations
Note that Automations is enterprise-only
Out of scope:
This PR introduces no broken links: https://github.com/wandb/docs/actions/runs/14136418817/job/39609105718
In peer review
Preview links for major changes: