perf: increase parquet arrow buffer size

[jessicaxiang]

This is a variable that we want to set fleet-wide (outside of the tiniest instances).

The bigger buffer lets us write more data into fewer files and row groups. Each row group adds memory overhead when reading, so fewer files and row groups makes reading much smoother.

The current default is 512MB, but that triggers a bit too easily (in some cases) due to how we measure the buffer size. Bumping to 2GB makes this more consistent, at the cost of higher memory consumption on export.

https://weightsandbiases.slack.com/archives/C010Y174QGH/p1738711339558679?thread_ts=1738455939.730879&cid=C010Y174QGH

Summary by CodeRabbit

• Chores

  • Updated the operator version from 0.25.3 to 0.25.4.

• New Features

  • Introduced a new environment variable for a 2GB memory buffer across multiple deployment configurations, enhancing data processing capabilities.

[danielpanzella]

I'm not sure this is sufficient, this configmap may not be mounted in all of the existing deployments

clear

[coderabbitai]

Walkthrough

This pull request updates the operator-wandb Helm chart by bumping its version from 0.25.3 to 0.25.4. Additionally, it introduces a new environment variable, GORILLA_PARQUET_ARROW_BUFFER_SIZE, set to "2147483648" (2GB), to the container configurations in multiple Kubernetes templates for deployments and cron jobs. No other modifications are present.

Changes

File(s)	Change Summary
charts/operator-wandb/Chart.yaml	Updated chart version from 0.25.3 to 0.25.4
charts/operator-wandb/.../deployment.yaml (app, executor, parquet) and charts/operator-wandb/.../cron.yaml	Added environment variable GORILLA_PARQUET_ARROW_BUFFER_SIZE with value "2147483648" to container specs
charts/operator-wandb/templates/gorilla.yaml	Added configuration entry GORILLA_PARQUET_ARROW_BUFFER_SIZE: "2147483648" in ConfigMap

Possibly related PRs

• fix: bucket needs to be used via include #341: Involves a version update in the Chart.yaml, similar to the update in this PR though to a different version.

Suggested reviewers

• vanpelt
• jsbroks
• danielpanzella

Poem

I'm a rabbit hopping with glee,
Chart versions leap as far as I see,
With a buffer so vast—2GB in might,
New env settings bring our YAML delight,
Hopping along in code so bright,
Celebrating changes from morning to night!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67bd42f and 4eb4b61.

📒 Files selected for processing (1)

• charts/operator-wandb/templates/gorilla.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: lint-test

🔇 Additional comments (1)

charts/operator-wandb/templates/gorilla.yaml (1)

65-65: New Environment Variable for Increased Parquet Arrow Buffer Size

The added configuration GORILLA_PARQUET_ARROW_BUFFER_SIZE: "2147483648" # 2GB clearly implements the PR objective by increasing the buffer size. Please ensure that downstream pods or jobs consuming this setting have adequate memory limits configured to handle the increased allocation.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

charts/operator-wandb/charts/app/templates/deployment.yaml (1)

311-313: Integration of Buffer Size Variable in App Deployment:
The new environment variable GORILLA_PARQUET_ARROW_BUFFER_SIZE with a value of "2147483648" (2GB) is consistently added in the app deployment template. This ensures uniform behavior across the system regarding Parquet operations. One suggestion: consider making this value configurable via the Helm values (if it isn’t already) to allow easier tuning in the future without modifying the template directly.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc47d47 and 67bd42f.

📒 Files selected for processing (5)

• charts/operator-wandb/Chart.yaml (1 hunks)
• charts/operator-wandb/charts/app/templates/deployment.yaml (1 hunks)
• charts/operator-wandb/charts/executor/templates/deployment.yaml (1 hunks)
• charts/operator-wandb/charts/parquet/templates/cron.yaml (1 hunks)
• charts/operator-wandb/charts/parquet/templates/deployment.yaml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• charts/operator-wandb/Chart.yaml

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: lint-test

🔇 Additional comments (3)

charts/operator-wandb/charts/parquet/templates/cron.yaml (1)

129-131: New Environment Variable Addition in CronJob:
The new GORILLA_PARQUET_ARROW_BUFFER_SIZE is correctly added with a value of "2147483648" (2GB). This change clearly aligns with the performance objectives of reducing excessive row groups and minimizing overhead during Parquet exports.

charts/operator-wandb/charts/executor/templates/deployment.yaml (1)

160-162: Consistent Buffer Size Configuration in Executor Deployment:
The GORILLA_PARQUET_ARROW_BUFFER_SIZE environment variable has been added with the appropriate value of "2147483648" (2GB). This update is consistent with similar changes in other components, ensuring that the executor benefits from the intended performance improvement while writing Parquet files.

charts/operator-wandb/charts/parquet/templates/deployment.yaml (1)

190-192: Environment Variable Addition in Parquet Deployment:
The addition of the GORILLA_PARQUET_ARROW_BUFFER_SIZE variable with the value "2147483648" (2GB) is implemented correctly in the deployment configuration. This ensures that the service handling Parquet operations uses a larger buffer, which can help to reduce memory overhead during reads by consolidating row groups.