feat(operator-wandb): add mailFrom to SMTP config#585
Merged
Conversation
Remove stale seLinuxOptions: null from redis StatefulSet across all existing snapshot files due to Bitnami redis chart update.
Adds global.email.smtp.mailFrom to set GORILLA_EMAIL_FROM_ADDRESS, removing the need to use global.extraEnv as a workaround. Supports both plain string values and valueFrom secret references.
mwhooker
approved these changes
Apr 13, 2026
Contributor
mwhooker
left a comment
mwhooker
left a comment
There was a problem hiding this comment.
I think this is correct. Please fix the snapshots errors
Restore seLinuxOptions: null in Redis StatefulSet across all snapshots. This line was incorrectly removed using Helm v4 locally, but CI runs Helm v3.20.1 which renders it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
global.email.smtp.mailFromto setGORILLA_EMAIL_FROM_ADDRESSnatively, removing the need forglobal.extraEnvworkaroundvalueFromsecret references, consistent with existing SMTP fields (host, port, user, password)mailFromis non-empty, so zero impact on existing deploymentsTest plan
mailFrom(snap-smtp-mail-from.yaml)valueFromsecret ref (snap-smtp-mail-from-secret.yaml)./snapshots.sh run— 34/34 PASS)GORILLA_EMAIL_FROM_ADDRESSis not emitted whenmailFromis emptySummary by CodeRabbit
New Features
Tests
Chores