fix(ui): Paginated rows don't consistently have the same sort order #3581
+29
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To replicate:
This is because the database does not return a stable order when multiple rows have the same sort value - each page of the pagination will push a random ordering of items within the sort set.
Places where this could be a problem would be if a user was scoring a scorer by pass/fail and annotating them - on pagination they may be presented with items already annotated, and miss others in their list.
Proposed fix:
started_at
sort as a secondary sort when needed.