Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(weave): sort datasets while editing #3591

Merged
merged 1 commit into from
Feb 10, 2025
Merged

chore(weave): sort datasets while editing #3591

merged 1 commit into from
Feb 10, 2025
+7 −17

Conversation

bcsherma
Copy link
Contributor

@bcsherma bcsherma commented Feb 4, 2025 •
edited
Loading

Description

Make datasets sortable in edit mode and preserve row indices during sorting operations.

@bcsherma bcsherma mentioned this pull request Feb 4, 2025
Merged
@bcsherma Graphite App
Copy link
Contributor Author

bcsherma commented Feb 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@circle-job-mirror
Copy link

circle-job-mirror bot commented Feb 4, 2025 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=ef279495f0ddab7ad68ab618f0bc6f4511762bd5

@bcsherma bcsherma force-pushed the sort-dataset-while-editing branch from 546735e to 5c41397 Compare February 4, 2025 19:57
@bcsherma bcsherma marked this pull request as ready for review February 4, 2025 19:57
@bcsherma bcsherma requested review from a team as code owners February 4, 2025 19:57
@bcsherma bcsherma force-pushed the server-table-row-index branch from 3ee5fbd to a1f7dc6 Compare February 4, 2025 23:41
@bcsherma bcsherma force-pushed the sort-dataset-while-editing branch 2 times, most recently from 1dca0e5 to 357c659 Compare February 5, 2025 23:46
@bcsherma bcsherma force-pushed the server-table-row-index branch from a1f7dc6 to e5c77bb Compare February 5, 2025 23:46
@bcsherma bcsherma force-pushed the sort-dataset-while-editing branch from 357c659 to 72b1cf6 Compare February 6, 2025 01:04
@bcsherma bcsherma force-pushed the server-table-row-index branch from e5c77bb to 8ac6e07 Compare February 6, 2025 01:04
tssweeney
tssweeney reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable - since this is a stacked PR, will wait for approval after the base is merged

@bcsherma bcsherma force-pushed the sort-dataset-while-editing branch from 72b1cf6 to 659cafe Compare February 8, 2025 00:10
@bcsherma bcsherma force-pushed the server-table-row-index branch from 8ac6e07 to 43131de Compare February 8, 2025 00:10
@bcsherma bcsherma force-pushed the sort-dataset-while-editing branch from 659cafe to 660d501 Compare February 8, 2025 00:14
@bcsherma bcsherma force-pushed the server-table-row-index branch 2 times, most recently from 907697b to c3dc8ec Compare February 8, 2025 00:35
@bcsherma bcsherma force-pushed the sort-dataset-while-editing branch from 660d501 to 0f012fa Compare February 8, 2025 00:35
@bcsherma bcsherma force-pushed the server-table-row-index branch from c3dc8ec to 99dbe7b Compare February 8, 2025 01:15
@bcsherma bcsherma force-pushed the sort-dataset-while-editing branch from 0f012fa to 76ce011 Compare February 8, 2025 01:15
Base automatically changed from server-table-row-index to master February 8, 2025 01:59
@bcsherma bcsherma requested a review from tssweeney February 10, 2025 17:18
tssweeney
tssweeney approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, you might want to split this into server and UI changes, deploy server, then land UI - else the UI is relying on a field that won't be coming back. This is super minor, so consider this not blocking, but is good practice.

@bcsherma
Copy link
Contributor Author

Technically, you might want to split this into server and UI changes, deploy server, then land UI - else the UI is relying on a field that won't be coming back. This is super minor, so consider this not blocking, but is good practice.

That's the plan!

@bcsherma bcsherma force-pushed the sort-dataset-while-editing branch from 76ce011 to c27a6c5 Compare February 10, 2025 17:44
@bcsherma bcsherma merged commit 1431de3 into master Feb 10, 2025
132 checks passed
@bcsherma bcsherma deleted the sort-dataset-while-editing branch February 10, 2025 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
@bcsherma bcsherma restored the sort-dataset-while-editing branch February 10, 2025 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tssweeney tssweeney tssweeney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcsherma @tssweeney