Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): add highlighting to Tag #3593

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amusipatla-wandb
Copy link

@amusipatla-wandb amusipatla-wandb commented Feb 4, 2025

Description

adds a highlightedText prop to the Tag component so that it can be used for the global search in registry designs, where we want to highlight matched search terms in artifact/collection tags and aliases like so:

Screenshot 2025-02-04 at 3 17 47 PM

figma here: https://www.figma.com/design/JqVarIxY1vfMLT6RJGpFOn/Art%2FReg%2FAut---Archived?m=auto&node-id=2991-106911&t=9eyMrIagVIrTLBgF-1

Testing

Tested in an fe PR that's using this component: https://github.com/wandb/core/pull/27256

Screenshot 2025-02-05 at 1 57 45 PM
Screenshot 2025-02-05 at 1 57 38 PM

@amusipatla-wandb amusipatla-wandb requested a review from a team as a code owner February 4, 2025 21:01
Copy link
Contributor

github-actions bot commented Feb 4, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@circle-job-mirror
Copy link

circle-job-mirror bot commented Feb 4, 2025

@amusipatla-wandb
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 5, 2025
@amusipatla-wandb amusipatla-wandb marked this pull request as draft February 5, 2025 18:52
@amusipatla-wandb amusipatla-wandb marked this pull request as ready for review February 5, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants