Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): extend runs history step slider to include history tables from all runs #3599

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nicholaspun-wandb
Copy link
Contributor

@nicholaspun-wandb nicholaspun-wandb commented Feb 5, 2025

Description

  • Implements WB-23062
  • Followup to feat(app): Runs History Tables Scrubber #3459
  • The panel now retrieves history data from all runs (instead of just the latest) and performs the following query:
    runs.history.concat.filter((row) => row['step'] == <step>)[<table>]
    
    for the specified <step> (given by the slider on the bottom) and <table> (selected in the config)

Testing

Local FE

Screen.Recording.2025-02-05.at.10.56.17.AM.mov

Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this with existing panels that have been pre-configured, then render with this UI?

Also, is the screencast UI final? Seems like there are some clear padding issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants