Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weave): run sync eval predict functions in parallel #3652

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented Feb 11, 2025

Description

Once again allow sync functions to execute in parallel, respecting WEAVE_PARALLELISM in evaluations.

Broken by this refactor

Testing

Branch:
Screenshot 2025-02-10 at 5 31 10 PM

Master:
Screenshot 2025-02-10 at 5 31 22 PM

@gtarpenning gtarpenning marked this pull request as ready for review February 11, 2025 01:31
@gtarpenning gtarpenning requested a review from a team as a code owner February 11, 2025 01:31
@gtarpenning gtarpenning changed the title fix(weave): run non-async eval predict functions in parallel fix(weave): run sync eval predict functions in parallel Feb 11, 2025
@circle-job-mirror
Copy link

circle-job-mirror bot commented Feb 11, 2025

@gtarpenning gtarpenning enabled auto-merge (squash) February 11, 2025 01:58
@gtarpenning gtarpenning merged commit dbfe828 into master Feb 11, 2025
131 checks passed
@gtarpenning gtarpenning deleted the griffin/async-parallel-fix branch February 11, 2025 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants