-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update references for old repository name #127
chore: update references for old repository name #127
Conversation
Waiting on CI builds to be fixed in #126 before we merge this PR. |
Not sure why it's not getting triggered in your case. Maybe it's related to the repository name/branch changes. I had updated the HEAD for both origin and upstream as opposed to just origin as mentioned here - https://github.com/warm-metal/container-image-csi-driver#note-for-forked-repositories git branch -m master main
git remote set-url upstream [email protected]:warm-metal/container-image-csi-driver.git
git remote set-url origin [email protected]:mbtamuli/container-image-csi-driver.git
git fetch origin
git fetch upstream
git branch -u main main
git remote set-head origin -a
git remote set-head upstream -a Are you sure you've updated your fork correctly? For #126, the workflows are getting triggered. |
* Update go.mod * Update package imports * Update Dockerfiles * Update docs * Update scripts
87a78de
to
beaa4f4
Compare
I think the workflows got triggered for #126 because it had the changes to fix the CI. As for updating my fork, I re-created my fork after name change so I don't think the issue is related to my fork. And now the workflows got triggered after I rebased this PR with your CI changes. |
@mugdha-adhav Please change the name as well in your PR - "image": "ghcr.io/warm-metal/csi-driver-image/devcontainer:latest",
+ "image": "ghcr.io/warm-metal/container-image-csi-driver/devcontainer:latest", |
* Update docker images for tests * Fix make targets for test-deps
Not just the name, but I think we'll also need to update all the references of |
I tried updating all references of older repository in a single PR, but it's getting too large and hard to track. Reverted some of the recent commits. Will create separate PRs for those changes. @mbtamuli JFYI, your dev-container related change will also go in one of the follow up PR. |
@mugdha-adhav I understand. I'll take care of raising a PR related to any devcontainer updates. |
Co-authored-by: Mriyam Tamuli <[email protected]>
Related to #105
Updating references for
csi-driver-image
tocontainer-image-csi-driver
in the listed files/packages.