Code

Alternate, Simplified Async Pull#137

Code

Merged

mugdha-adhav merged 46 commits intowarm-metal:mainwarm-metal/container-image-csi-driver:mainfrom imuni4fun:async-pull-jkimuni4fun/container-image-csi-driver:async-pull-jkCopy head branch name to clipboardMar 4, 2024

+746-572

Commits

Commits on Feb 5, 2024

• rebased updated async implementation onto main, review "//TODO:" entries

  imuni4fun

  committed
  941d2ee

  Copy full SHA for 941d2ee

• simplified RunCompletionChecker() loop exit

  imuni4fun

  committed
  cfc23bd

  Copy full SHA for cfc23bd

Commits on Feb 6, 2024

• updated logging

  imuni4fun

  committed
  c98e7d6

  Copy full SHA for c98e7d6

• updated chart to use new flag

  imuni4fun

  committed
  b9b5962

  Copy full SHA for b9b5962

• removed previous async files

  imuni4fun

  committed
  d65aef7

  Copy full SHA for d65aef7

Commits on Feb 9, 2024

• changed to sync from async for this test which may match original intent

  imuni4fun

  committed
  b6b702d

  Copy full SHA for b6b702d

• rebased updated async implementation onto main, review "//TODO:" entries

  

  imuni4fun

  authored and

  mugdha-adhav

  committed
  7a688f2

  Copy full SHA for 7a688f2

• simplified RunCompletionChecker() loop exit

  

  imuni4fun

  authored and

  mugdha-adhav

  committed
  c497347

  Copy full SHA for c497347

• updated logging

  

  imuni4fun

  authored and

  mugdha-adhav

  committed
  75b2517

  Copy full SHA for 75b2517

• updated chart to use new flag

  

  imuni4fun

  authored and

  mugdha-adhav

  committed
  8374809

  Copy full SHA for 8374809

• removed previous async files

  

  imuni4fun

  authored and

  mugdha-adhav

  committed
  6ff665b

  Copy full SHA for 6ff665b

• changed to sync from async for this test which may match original intent

  

  imuni4fun

  authored and

  mugdha-adhav

  committed
  fbd31d5

  Copy full SHA for fbd31d5

• added async puller startup log messages

  imuni4fun

  committed
  c206d9d

  Copy full SHA for c206d9d

Commits on Feb 12, 2024

• fixed omission of setting imageSvc

  imuni4fun

  committed
  fdef232

  Copy full SHA for fdef232

• updated ephemeral volume yaml to always pull. not doing this masked fact that pull was not occurring.

  imuni4fun

  committed
  22b486f

  Copy full SHA for 22b486f

• added initial kind doc and Makefile targets, added ephemeral-volume-set.yaml to load multiple jobs in parallel

  imuni4fun

  committed
  d805aeb

  Copy full SHA for d805aeb

• updated doc

  imuni4fun

  committed
  7a7b0f0

  Copy full SHA for 7a7b0f0

• added final steps to fully flush the ephemeral volume and verify async pull logic functions properly via fully integrated kind test

  imuni4fun

  committed
  1aece15

  Copy full SHA for 1aece15

• Merge remote-tracking branch 'fork/async-pull-jk' into async-pull-jk

  imuni4fun

  committed
  6974562

  Copy full SHA for 6974562

Commits on Feb 14, 2024

• resolved session state bug, reintroduced metrics, updated metrics test

  imuni4fun

  committed
  a937ec6

  Copy full SHA for a937ec6

• fixed elapsed calc

  imuni4fun

  committed
  89adc0e

  Copy full SHA for 89adc0e

• added removal of pull time info after 1 minute expiration

  imuni4fun

  committed
  d31d47d

  Copy full SHA for d31d47d

Commits on Feb 15, 2024

• remove unintended Makefile changes

  imuni4fun

  committed
  b9cd81a

  Copy full SHA for b9cd81a

• reverted to simple-fs from ubuntu on sample volume yaml

  imuni4fun

  committed
  49207fa

  Copy full SHA for 49207fa

• Merge remote-tracking branch 'origin/main' into async-pull-jk

  imuni4fun

  committed
  1531ae6

  Copy full SHA for 1531ae6

• fixed conflict resolution oversight

  imuni4fun

  committed
  84109f4

  Copy full SHA for 84109f4

• added async error return unit test

  imuni4fun

  committed
  613debd

  Copy full SHA for 613debd

Commits on Feb 16, 2024

• simplified async implementation further

  imuni4fun

  committed
  901c5d2

  Copy full SHA for 901c5d2

• extracted changes for dev experience PR for issue warm-metal#143

  imuni4fun

  committed
  74edb81

  Copy full SHA for 74edb81

• operation error metric cleanup

  imuni4fun

  committed
  074db0e

  Copy full SHA for 074db0e

• introduced image size metric in similar pattern to image pull time

  imuni4fun

  committed
  5fad043

  Copy full SHA for 5fad043

• added pull time and size logs, added error handling to image size check (after panic seen locally in kind), added size metrics, added size error count metric

  imuni4fun

  committed
  3921e6c

  Copy full SHA for 3921e6c

Commits on Feb 21, 2024

• reverted Makefile change... this was extracted to another PR

  imuni4fun

  committed
  88f6a39

  Copy full SHA for 88f6a39

• added integration test for async pull feature

  imuni4fun

  committed
  62fc0d0

  Copy full SHA for 62fc0d0

Commits on Feb 22, 2024

• removed missed status definitions from previous async implementation

  imuni4fun

  committed
  1879256

  Copy full SHA for 1879256

• replaced completionChan and loop with completionFunc

  imuni4fun

  committed
  48fcd61

  Copy full SHA for 48fcd61

• removed isComplete, did not make changes to replace isTimeout and other result type checks with method calls since i felt this was becoming too rigid... especially when considering logging

  imuni4fun

  committed
  17c1c87

  Copy full SHA for 17c1c87

• updated timeout to be more verbose

  imuni4fun

  committed
  8b54915

  Copy full SHA for 8b54915

• fixed bug where one call to StartAsyncPuller() in node_server.go was not updated to remove completionChan depth and the build targets still succeeded. should have failed integration tests if executed.

  imuni4fun

  committed
  b5d6c03

  Copy full SHA for b5d6c03

Commits on Feb 23, 2024

• implemented test organization improvements from discussion

  imuni4fun

  committed
  b824954

  Copy full SHA for b824954

Commits on Feb 26, 2024

• captured comment updates

  imuni4fun

  committed
  4c6d716

  Copy full SHA for 4c6d716

Commits on Feb 28, 2024

• implemented change for exposing Image() on PullSession

  imuni4fun

  committed
  a75a0be

  Copy full SHA for a75a0be

• added configurability of asyncPullTimeout to helm deployment yaml

  imuni4fun

  committed
  6f13aba

  Copy full SHA for 6f13aba

• fixed buG resulting from uniform extraction of image string from docker.Named struct

  imuni4fun

  committed
  f3cd52d

  Copy full SHA for f3cd52d

Commits on Feb 29, 2024

• addressed two comments, replaced use of docker.Named.String() with Puller getter method Puller.ImageWithTag()

  imuni4fun

  committed
  6c28744

  Copy full SHA for 6c28744

Commits on Mar 4, 2024

• Updating Chart.yaml and Makefile

  mugdha-adhav

  committed
  2ec4f6f

  Copy full SHA for 2ec4f6f