Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wip max in-flight pulls #81

Closed
wants to merge 18 commits into from
Closed

feat: wip max in-flight pulls #81

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0815c27
test: use mock puller and mounter in the node server tests
vadasambar Dec 13, 2023
7933a30
feat: max in-flight pulls
vadasambar Dec 13, 2023
b909d2c
chore: fix missed merge conflict
vadasambar Jan 4, 2024
1c7bb79
test: fix node server tests failing
vadasambar Jan 4, 2024
0fcdc0b
feat: add flag for async pull timeout
vadasambar Jan 10, 2024
41bf90d
fix: `./test-metrics.sh` not found in CI
vadasambar Jan 11, 2024
2a93b0d
test: fix CI tests failing for max-in-flight pulls
vadasambar Jan 11, 2024
eaa4e3a
test: add debug ssh step to debug failing CI
vadasambar Jan 15, 2024
c04b199
refactor: remove redundant code from test script
vadasambar Jan 15, 2024
1bb30d0
test: trigger CI with debug ssh action
vadasambar Jan 15, 2024
d402232
test: uncomment integration tests
vadasambar Jan 15, 2024
0e85cb6
test: trigger CI
vadasambar Jan 15, 2024
60dc8fb
test: trigger CI again
vadasambar Jan 15, 2024
886ef30
🤖 Trigger CI run
vadasambar Jan 15, 2024
b191740
test: add debug ssh step
vadasambar Jan 15, 2024
372f29d
🤖 Trigger CI run 2
vadasambar Jan 15, 2024
f8f112e
test: remove ssh step
vadasambar Jan 15, 2024
af17fe5
refactor: use mutex per key instead of per goroutine
vadasambar Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/containerd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ jobs:
--set csiPlugin.enableAsyncPullMount=true \
--wait \
--debug
- name: debug using ssh
uses: lhotari/action-upterm@v1
# - name: debug using ssh
# uses: lhotari/action-upterm@v1
- name: Run Tests
run: test/integration/test-max-in-flight-pulls.sh
- name: Uninstall the CSI Driver (for `--max-in-flight-pulls`)
Expand Down
2 changes: 1 addition & 1 deletion cmd/plugin/node_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (n NodeServer) NodePublishVolume(ctx context.Context, req *csi.NodePublishV
return
}

// to trigger CI
// to trigger CI again
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadasambar You might consider using allow-empty. You'll not need to remove any unnecessary lines later.

git commit --allow-empty --message "🤖 Trigger CI run"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful. Thank you Mriyam.


if _, isBlock := req.VolumeCapability.AccessType.(*csi.VolumeCapability_Block); isBlock {
err = status.Error(codes.InvalidArgument, "unable to mount as a block device")
Expand Down
Loading