Add checksum input and update the upload files to S3 steps #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddytpc1
requested changes
Oct 14, 2024
| run: | | ||
| aws s3 cp ${{ github.workspace }}/${{ env.WAZUH_VERSION }}/${{ env.WAZUH_INSTALL_NAME }}.sha512 s3://${{ env.S3_BUCKET }}/${{ env.S3_REPOSITORY_PATH }}/${{ env.WAZUH_VERSION }}/ | ||
| s3uri="s3://${{ env.S3_BUCKET }}/${{ env.S3_REPOSITORY_PATH }}/${{ env.WAZUH_VERSION }}/${{ env.WAZUH_INSTALL_NAME }}.sha512" | ||
| echo "S3 sha512 wazuh-install-tool checksum URI: ${s3uri}" |
There was a problem hiding this comment.
Remove the -tool string from wazuh-install.
| id: | ||
| description: "ID used to identify the workflow uniquely." | ||
| type: string | ||
| required: false | ||
| workflow_call: | ||
| inputs: | ||
| WAZUH_INSTALLATION_ASSISTANT_REFERENCE: |
There was a problem hiding this comment.
Use lowercase for the input names: WAZUH_INSTALLATION_ASSISTANT_REFERENCE
Lines: 7 and 25, and update the references.
c-bordon
approved these changes
Oct 16, 2024
teddytpc1
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to add the mandatory checksum field to the workflow for building the installation assistant packages.
With this, a new step has been added to generate the
sha512files and another step to upload them to S3.Additionally, an
echowith the URI of each file uploaded to S3 has been added to better identify it.Note
This step implies that we have to upload the installation assistant files one by one to correctly obtain the URI of each file.
Workflow output test
Related issue