Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content database in RPM and DEB packages #2695

Merged
merged 13 commits into from
Dec 31, 2023

Conversation

diegodfrf
Copy link
Contributor

@diegodfrf diegodfrf commented Dec 18, 2023

Related issue
#20747

Description

Adds the option to download the vulnerability detector content, compress it into a tar.xz file, add it to the installer, and unzip it at installation.

Tests

  • New flag --download-content in DEB

image

  • New flag --download-content in RPM

image

  • Generation DEB package successful

image

  • Installation from DEB packages successful

image

image

  • Generation RPM package successful

image

  • Installation from RPM packages successful

image

image

@diegodfrf diegodfrf self-assigned this Dec 18, 2023
@diegodfrf diegodfrf added level/task Subtask issue type/enhancement Enhancement issue labels Dec 18, 2023
@diegodfrf diegodfrf force-pushed the 20747-add-content-databases branch 2 times, most recently from 576c248 to 3ac2af1 Compare December 19, 2023 19:35
@diegodfrf diegodfrf marked this pull request as ready for review December 19, 2023 19:38
@diegodfrf diegodfrf changed the title Add content databases Add content database in RPM and DEB packages Dec 19, 2023
@diegodfrf diegodfrf force-pushed the 20747-add-content-databases branch from bfcbafa to 3cfce23 Compare December 21, 2023 23:04
@diegodfrf diegodfrf linked an issue Dec 21, 2023 that may be closed by this pull request
6 tasks
@Dwordcito Dwordcito requested a review from pereyra-m December 26, 2023 13:40
Copy link
Member

@pereyra-m pereyra-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj!

@diegodfrf diegodfrf force-pushed the 20747-add-content-databases branch from d7a0305 to fb2153b Compare December 27, 2023 23:22
@diegodfrf diegodfrf force-pushed the 20747-add-content-databases branch from fb2153b to e152a5e Compare December 28, 2023 17:09
@diegodfrf diegodfrf requested a review from pereyra-m December 28, 2023 19:51
Copy link
Member

@pereyra-m pereyra-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pereyra-m
Copy link
Member

Testing 🟢

Packages generated by @MiguelazoDS .

The .deb package was installed and the content was present

root@ubuntu-jammy:/var/ossec# du -hs queue/vd*
4.5G	queue/vd
116K	queue/vd_updater
root@ubuntu-jammy:/var/ossec# du -hs queue/vd/*
1.5G	queue/vd/candidates
2.9G	queue/vd/cves
131M	queue/vd/descriptions
48K	queue/vd/inventory
34M	queue/vd/remediations
56K	queue/vd/translations

Also, the content_module reads the offset properly

2023-12-29_15-08

The .rpm package was installed and the content was present

[root@localhost ossec]# du -hs queue/vd*
4.5G	queue/vd
4.2M	queue/vd_updater
[root@localhost ossec]# du -hs queue/vd/*
1.5G	queue/vd/candidates
2.9G	queue/vd/cves
135M	queue/vd/descriptions
4.1M	queue/vd/inventory
38M	queue/vd/remediations
4.1M	queue/vd/translations

2023-12-29_15-17

@Dwordcito Dwordcito merged commit e5af547 into dev-14153-vulndet-refactor Dec 31, 2023
46 of 63 checks passed
@Dwordcito Dwordcito deleted the 20747-add-content-databases branch December 31, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Subtask issue type/enhancement Enhancement issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add content databases to the manager package
3 participants