Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path used by homebrew for macOS Sonoma UTs #24519

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

MarcelKemp
Copy link
Member

@MarcelKemp MarcelKemp commented Jul 9, 2024

Related issue
#24517

Description

The Homebrew path for macOS Sonoma has been modified, so it has been necessary to adapt the compiler paths to find the cmocka package installed via brew.

  • macOS Ventura: /usr/local/
  • macOS Sonoma: /opt/homebrew/

Base branch changed to 4.9.0, as 4.8.1 does not have the necessary dependencies to compile macOS ARM.

Logs/Alerts example

2: [----------] Global test environment tear-down
2: [==========] 16 tests from 1 test suite ran. (31 ms total)
2: [  PASSED  ] 16 tests.
2/2 Test #2: sys_normalizer_unit_test .........   Passed    0.05 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) =  46.25 sec

Tests

@MarcelKemp MarcelKemp requested a review from vikman90 July 9, 2024 14:22
@MarcelKemp MarcelKemp linked an issue Jul 9, 2024 that may be closed by this pull request
@MarcelKemp MarcelKemp changed the base branch from 4.8.1 to 4.9.0 July 9, 2024 14:33
@MarcelKemp MarcelKemp force-pushed the fix/24517-macos-sonoma-UTs branch from ad86571 to b5300fe Compare July 9, 2024 14:33
Copy link
Member

@vikman90 vikman90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Known issues

🔴 Wazuh CI / Build Linux arm64v8 manager rpm package

Relaunched

🔴 Wazuh CI / Build Linux x86_64 manager rpm package

🟢 Wazuh CI / Build Linux i386 agent deb package
🟢 Wazuh CI / Build Linux amd64 manager deb package
🟢 Wazuh CI / RTR scan-build test module agent
🟡 Wazuh CI / Unit tests: cmocka server

Conclusion

The failing / pending checks are not related to this change.
LGTM.

@vikman90 vikman90 merged commit cf667b5 into 4.9.0 Jul 10, 2024
28 of 31 checks passed
@vikman90 vikman90 deleted the fix/24517-macos-sonoma-UTs branch July 10, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS Sonoma unit tests fail due to homebrew path change
2 participants