Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit process cleanly on SIGINT, SIGTERM, and SIGUSR2 signals #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carpie
Copy link

@carpie carpie commented Apr 10, 2018

Hi!

We are using this plugin for SSR workflow to take advantage of cssnext functionality. In our development workflow we run babel-node through nodemon. When nodemon restarts, it uses the SIGUSR2 signal to cause restarts in child processes. This plugin restarts and reports that it cannot create a new server because the existing one is already running and exists. (It seems to be because the socket didn't get cleaned up.) Also, when we exit nodemon, we have to interrupt twice to get the postcss-server process to end.

This PR represents the tweaks I came up with to use this plugin for our workflow. If it works for other work flows, it would be great if it could be merged!

The basic changes are to cause the postcss-server to exit on any of the handled signals and delegate the exit handler to clean up the server socket (since it's called in all cases).

Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db00bdc on carpie:master into ce92e02 on wbyoung:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db00bdc on carpie:master into ce92e02 on wbyoung:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants