Fix mutable data#14
Open
exqlnet wants to merge 4 commits into
Open
Conversation
Make node length definition more clearly
Closed
mcdee
requested changes
Mar 15, 2024
Collaborator
mcdee
left a comment
mcdee
left a comment
There was a problem hiding this comment.
Thanks for this; a couple of requests.
| @@ -43,7 +43,12 @@ func (f parameterFunc) apply(p *parameters) { | |||
| // WithData sets the data for the merkle tree. | |||
Collaborator
There was a problem hiding this comment.
Please could you add a note here that this copies the data?
| // Test proof for all combinations of data. | ||
| var proof *MultiProof | ||
| combinations := 1<<len(test.data) - 1 | ||
| combinations := 1<<len(tree.Data) - 1 |
Collaborator
There was a problem hiding this comment.
There are other tests that use test.data in a similar fashion, please could you update those as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's safer to use copy of data while constructing the tree. Found this bug because I failed to pass
NewTreetest separately whilego test ./...passed. So there are also some problems with unittest answer.