Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal implementation of cookies #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohe2015
Copy link

No description provided.

@flosse
Copy link
Member

flosse commented Dec 29, 2024

@mohe2015 Thanks for your contribution. Would you mind to refactor the code so that it does not depend on serde?
The -sys crate is a minimal wrapper that should have minimal overhead. More comfortable API can be implemented in crates with higher abstraction.
Thanks!

@mohe2015
Copy link
Author

mohe2015 commented Dec 29, 2024

@mohe2015 Thanks for your contribution. Would you mind to refactor the code so that it does not depend on serde?
The -sys crate is a minimal wrapper that should have minimal overhead. More comfortable API can be implemented in crates with higher abstraction.
Thanks!

Should I use JsValue for the inputs then? So this basically just becomes these two extern function declarations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants