Skip to content

feat(progress-plugin)!: replace handler rest args with structured info object#13049

Merged
chenjiahan merged 10 commits intomainfrom
progress_message_0212
Feb 13, 2026
Merged

feat(progress-plugin)!: replace handler rest args with structured info object#13049
chenjiahan merged 10 commits intomainfrom
progress_message_0212

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Feb 12, 2026

API changes

This PR introduces a breaking API change to ProgressPlugin handler arguments:

// before
new rspack.ProgressPlugin((percentage, message ...args) => {
  // args: string[]
});

// after
new rspack.ProgressPlugin((percentage, message, info) => {
  // info: { builtModules: number; moduleIdentifier?: string }
});

Message changes

This PR also smplifies ProgressPlugin messages to make logs clearer and easier to read.

Before

image

All messages:

  • setup compilation
  • make
  • building {the long module identifier}
  • building finish make
  • sealing finish modules
  • sealing plugins
  • sealing dependencies
  • sealing module optimization
  • sealing after module optimization
  • sealing chunk optimization
  • sealing module and chunk tree optimization
  • sealing chunk modules optimization
  • sealing module ids
  • sealing chunk ids
  • sealing code generation
  • sealing asset processing
  • sealing after asset optimization
  • emitting emit
  • emitting after emit

After

image

All messages:

  • build start
  • build modules
  • build modules (N)
  • build modules done
  • finish modules
  • start sealing
  • optimize dependencies
  • optimize modules
  • optimize modules done
  • optimize chunks
  • optimize graph
  • optimize chunk modules
  • assign module ids
  • assign chunk ids
  • generate code
  • process assets
  • process assets done
  • emit assets
  • done

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings February 12, 2026 06:59
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to simplify and clarify the ProgressPlugin output so build progress logs are easier to scan and interpret.

Changes:

  • Simplifies progress step messages (e.g., “build modules (N)”, “emit assets”, “done”) and removes extra state item strings from default output paths.
  • Adjusts update throttling cadence and resets module-tracking state at the start of make.
  • Refactors default/profile and progress-bar handlers to accept fewer message components.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 825.4 KB 0
react-5k 2.7 MB 0
ui-components 2.2 MB 0
rome 984.2 KB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

📦 Binary Size-limit

Comparing a5bd68e to docs: standardize heading case in documentation (#13051) by neverland

🎉 Size decreased by 1.50KB from 48.68MB to 48.68MB (⬇️0.00%)

@chenjiahan chenjiahan requested a review from hardfist as a code owner February 12, 2026 08:21
@chenjiahan chenjiahan changed the title feat(progress): make progress plugin messages clearer feat(progress-plugin)!: replace handler rest args with structured info object Feb 12, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 12, 2026

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: a5bd68e
Status: ✅  Deploy successful!
Preview URL: https://891471d8.rspack-v2.pages.dev
Branch Preview URL: https://progress-message-0212.rspack-v2.pages.dev

View logs

@chenjiahan chenjiahan enabled auto-merge (squash) February 12, 2026 09:07
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing progress_message_0212 (a5bd68e) with main (f2d8d0a)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@chenjiahan chenjiahan merged commit 6d6c47a into main Feb 13, 2026
75 of 77 checks passed
@chenjiahan chenjiahan deleted the progress_message_0212 branch February 13, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants