Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include response content in WebPushException #59

Closed
alexsuh7 opened this issue Apr 30, 2019 · 2 comments
Closed

Include response content in WebPushException #59

alexsuh7 opened this issue Apr 30, 2019 · 2 comments

Comments

@alexsuh7
Copy link

When diagnosing WebPushException , it might be useful to include the body of the http response content received from google when calling the send rest API , as it might contain additional information , regarding cause of the error.
@marsimoto03
Copy link

I could also make use of that.

coryjthompson added a commit that referenced this issue Feb 27, 2021
@coryjthompson
#59, #63 Include response content in WebPushException & Improve the e…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
88d4fb1 
…rror message when the request fails
@coryjthompson
Copy link
Member

Thanks for the advice, this was released in v1.0.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coryjthompson @alexsuh7 @marsimoto03