Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Make custom DataHandler command in select boxes work #429

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

koehnlein
Copy link
Contributor

Fixes #428

I am not completely happy with the f:replace solution. But it worked for me. Feel free to consider this as a draft and create a more beautiful solution. 🙂

@koehnlein koehnlein force-pushed the bugfix-translate-by-select branch from 96a0899 to fad1e76 Compare February 6, 2025 09:57
@koehnlein koehnlein changed the title [BUGFIX] Make custom DataHandler command in select boxes [BUGFIX] Make custom DataHandler command in select boxes work Feb 6, 2025
In commit 0d4bc00 a custom DataHandler command was introduced for DeepL translations. This bugfix updates the "Translate with DeepL" select boxes in page module and list module to create translation records of pages.
@koehnlein koehnlein force-pushed the bugfix-translate-by-select branch from fad1e76 to bee56b0 Compare February 6, 2025 09:58
Copy link
Member

@calien666 calien666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, we can take the f:replace solution in first here.

@calien666 calien666 merged commit da13ab1 into web-vision:main Feb 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "Translate with DeepL" select boxes in page and list modules not working
2 participants