Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Injected provider integration tests #5606

Closed
wants to merge 2 commits into from

Conversation

mpetrunic
Copy link
Contributor

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist for 1.x:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Checklist for 4.x:

  • I have selected the correct 4.x base branch.
  • Within the description, the feature or issue is discussed in detail or an issue is linked.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added any required tests for the changes I made
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules.
  • I ran yarn successfully
  • I ran yarn lint successfully
  • I ran yarn build:web successfully
  • I ran yarn test:unit successfully
  • I ran yarn test:integration successfully
  • I ran compile:contracts successfully
  • I have tested my code.
  • I have updated the corresponding CHANGELOG.md file in the packages I have edited.

@mpetrunic mpetrunic changed the base branch from 1.x to 4.x November 10, 2022 09:58
@Muhammad-Altabba
Copy link
Contributor

Muhammad-Altabba commented Nov 10, 2022

Thanks @mpetrunic,

Actually, unfortunately, selecting 1.x as the target branch, and later changing the branch from 1.x to 4.x does not trigger the Pipeline for 4.x.
So, I think you need to close this MR and open a new one that has 4.x as the target branch. Except if you can trigger GitHub Actions somehow.

@mpetrunic mpetrunic closed this Nov 10, 2022
@mpetrunic mpetrunic reopened this Nov 10, 2022
@render
Copy link

render bot commented Nov 10, 2022

@mpetrunic
Copy link
Contributor Author

reopening PR seems to do the trick^^

@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jan 16, 2023
@mpetrunic
Copy link
Contributor Author

Already merged as part of: #5652

@mpetrunic mpetrunic closed this Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale Has not received enough activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants