Skip to content

Commit

Permalink
Remove certificate "pinning" for ComicsKingdom (fixes #291)
Browse files Browse the repository at this point in the history
They have switched to short-lived Google certificates, let's hope they
have automated their certificate setup enough so that chain issues won't
happen again...
  • Loading branch information
TobiX committed Oct 10, 2023
1 parent 5de53cb commit 85127de
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 59 deletions.
51 changes: 0 additions & 51 deletions dosagelib/data/godaddy-bundle-g2-2031.pem

This file was deleted.

8 changes: 0 additions & 8 deletions dosagelib/plugins/comicskingdom.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,6 @@ def __init__(self, name, path, lang=None):
if lang:
self.lang = lang

# slightly iffy hack taken from certifi
# We need or own certificate bundle since ComicsKingdom screws up their
# TLS setup from time to time, this should "fix" it)
self.cert_ctx = as_file(files('dosagelib.data') / 'godaddy-bundle-g2-2031.pem')
self.session.add_host_options('comicskingdom.com', {
'verify': str(self.cert_ctx.__enter__()),
})

@classmethod
def getmodules(cls): # noqa: CFQ001
return (
Expand Down

0 comments on commit 85127de

Please sign in to comment.