Fix destructuring assignment for deployment groups that have no previ…

…ous deployment
webfactory · Sep 15, 2020 · 250217b · 250217b
1 parent fc0c006
commit 250217b
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 24 deletions.
diff --git a/create-deployment.js b/create-deployment.js
@@ -73,24 +73,26 @@ exports.createDeployment = async function(applicationName, fullRepositoryName, b
         }
 
         if (runNumber) {
-            var {deploymentGroupInfo: {lastAttemptedDeployment: {deploymentId: lastAttemptedDeploymentId}}} = await codeDeploy.getDeploymentGroup({
+            var {deploymentGroupInfo: {lastAttemptedDeployment: {deploymentId: lastAttemptedDeploymentId} = {}}} = await codeDeploy.getDeploymentGroup({
                 applicationName: applicationName,
                 deploymentGroupName: deploymentGroupName,
             }).promise();
 
-            var {deploymentInfo: {description: lastAttemptedDeploymentDescription}} = await codeDeploy.getDeployment({
-                deploymentId: lastAttemptedDeploymentId,
-            }).promise();
+            if (lastAttemptedDeploymentId) {
+                var {deploymentInfo: {description: lastAttemptedDeploymentDescription}} = await codeDeploy.getDeployment({
+                    deploymentId: lastAttemptedDeploymentId,
+                }).promise();
 
-            var matches, lastAttemptedDeploymentRunNumber;
+                var matches, lastAttemptedDeploymentRunNumber;
 
-            if (matches = lastAttemptedDeploymentDescription.match(/run_number=(\d+)/)) {
-                lastAttemptedDeploymentRunNumber = matches[1];
-                if (parseInt(lastAttemptedDeploymentRunNumber) > parseInt(runNumber)) {
-                    core.setFailed(`🙅‍♂️ The last attempted deployment as returned by the AWS API has been created by a higher run number ${lastAttemptedDeploymentRunNumber}, this is run number ${runNumber}. Aborting.`);
-                    return;
-                } else {
-                    console.log(`🔎 Last attempted deployment was from run number ${lastAttemptedDeploymentRunNumber}, this is run number ${runNumber} - proceeding.`);
+                if (matches = lastAttemptedDeploymentDescription.match(/run_number=(\d+)/)) {
+                    lastAttemptedDeploymentRunNumber = matches[1];
+                    if (parseInt(lastAttemptedDeploymentRunNumber) > parseInt(runNumber)) {
+                        core.setFailed(`🙅‍♂️ The last attempted deployment as returned by the AWS API has been created by a higher run number ${lastAttemptedDeploymentRunNumber}, this is run number ${runNumber}. Aborting.`);
+                        return;
+                    } else {
+                        console.log(`🔎 Last attempted deployment was from run number ${lastAttemptedDeploymentRunNumber}, this is run number ${runNumber} - proceeding.`);
+                    }
                 }
             }
 

diff --git a/dist/index.js b/dist/index.js
@@ -89,24 +89,26 @@ exports.createDeployment = async function(applicationName, fullRepositoryName, b
         }
 
         if (runNumber) {
-            var {deploymentGroupInfo: {lastAttemptedDeployment: {deploymentId: lastAttemptedDeploymentId}}} = await codeDeploy.getDeploymentGroup({
+            var {deploymentGroupInfo: {lastAttemptedDeployment: {deploymentId: lastAttemptedDeploymentId} = {}}} = await codeDeploy.getDeploymentGroup({
                 applicationName: applicationName,
                 deploymentGroupName: deploymentGroupName,
             }).promise();
 
-            var {deploymentInfo: {description: lastAttemptedDeploymentDescription}} = await codeDeploy.getDeployment({
-                deploymentId: lastAttemptedDeploymentId,
-            }).promise();
+            if (lastAttemptedDeploymentId) {
+                var {deploymentInfo: {description: lastAttemptedDeploymentDescription}} = await codeDeploy.getDeployment({
+                    deploymentId: lastAttemptedDeploymentId,
+                }).promise();
 
-            var matches, lastAttemptedDeploymentRunNumber;
+                var matches, lastAttemptedDeploymentRunNumber;
 
-            if (matches = lastAttemptedDeploymentDescription.match(/run_number=(\d+)/)) {
-                lastAttemptedDeploymentRunNumber = matches[1];
-                if (parseInt(lastAttemptedDeploymentRunNumber) > parseInt(runNumber)) {
-                    core.setFailed(`🙅‍♂️ The last attempted deployment as returned by the AWS API has been created by a higher run number ${lastAttemptedDeploymentRunNumber}, this is run number ${runNumber}. Aborting.`);
-                    return;
-                } else {
-                    console.log(`🔎 Last attempted deployment was from run number ${lastAttemptedDeploymentRunNumber}, this is run number ${runNumber} - proceeding.`);
+                if (matches = lastAttemptedDeploymentDescription.match(/run_number=(\d+)/)) {
+                    lastAttemptedDeploymentRunNumber = matches[1];
+                    if (parseInt(lastAttemptedDeploymentRunNumber) > parseInt(runNumber)) {
+                        core.setFailed(`🙅‍♂️ The last attempted deployment as returned by the AWS API has been created by a higher run number ${lastAttemptedDeploymentRunNumber}, this is run number ${runNumber}. Aborting.`);
+                        return;
+                    } else {
+                        console.log(`🔎 Last attempted deployment was from run number ${lastAttemptedDeploymentRunNumber}, this is run number ${runNumber} - proceeding.`);
+                    }
                 }
             }