Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from netdata:master #278

Merged
merged 14 commits into from
Jan 8, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Jan 6, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Enhancements:

  • Update govmomi to v0.47.0.

dependabot bot and others added 2 commits January 6, 2025 10:09
…/src/go (#19322)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pull pull bot added the ⤵️ pull label Jan 6, 2025
Copy link

sourcery-ai bot commented Jan 6, 2025

Reviewer's Guide by Sourcery

This pull request updates the Netdata agent by upgrading the Go dependencies github.com/vmware/govmomi from version v0.46.3 to v0.47.0 and fixes a typo in the kickstart.sh script, correcting report_bad_sha256sums to report_bad_sha256sum.

Sequence diagram for SHA256 checksum verification in kickstart.sh

sequenceDiagram
    participant Installer as Kickstart Installer
    participant Verify as SHA256 Verification
    participant Report as Error Reporter

    Installer->>Verify: Check SHA256 sum
    alt Checksum mismatch
        Verify->>Report: Call report_bad_sha256sum
        Report-->>Installer: Return error details
        Installer->>Installer: Append to failed_files
    end
Loading

Class diagram showing govmomi dependency update

classDiagram
    class Netdata {
        +dependencies
    }
    class Govmomi {
        version: v0.47.0
    }
    Netdata --> Govmomi: uses
    note for Govmomi "Updated from v0.46.3 to v0.47.0"
Loading

File-Level Changes

Change Details Files
Upgrade the Go dependency github.com/vmware/govmomi
  • Update github.com/vmware/govmomi from v0.46.3 to v0.47.0 in go.mod
  • Update checksums in go.sum to reflect the changes in go.mod
src/go/go.mod
src/go/go.sum
Fix typo in kickstart.sh
  • Correct report_bad_sha256sums to report_bad_sha256sum
packaging/installer/kickstart.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

ilyam8 and others added 12 commits January 6, 2025 14:41
fix fds leak in health
…19330)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.33.0 to 0.34.0.
- [Commits](golang/net@v0.33.0...v0.34.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* do not load instances and dimensions for unknown contexts - instead of creating contexts and adding instances and dimensions

* node updates to NC

* unify all liveness calls

* prevent wanted cache size from getting negative
@pull pull bot merged commit dc638c4 into webfutureiorepo:master Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants