[pull] master from netdata:master #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Add LTO support in CMake build system. Internally, CMake calls LTO ‘Interprocedural Optimization’, and it provides functionality for checking for support for this as well as enabling it by default for targets. This leverages that support to auto-detect LTO and enable it if it’s supported. * Default to disabling LTO for Debug builds. * Add handling for LTO to netdata installer code. * Switch back to DISABLE_LTO as option name. Using `ENABLE_LTO` leads to a possibility for confusion among users, as it does behave in the most intuitive manner. Instead of ensuring that LTO is used (and thus behaving like every other `ENABLE_*` option we have), it allows the usage LTO if it’s supported. Thus a build with `-DENABLE_LTO=True` may not actually be built with LTO. By instead using `DISABLE_LTO`, the behavior matches up directly with how most people are likely to interpret the meaning, because a build with `-DDISABLE_LTO=True` will _never_ have LTO flags added to the compiler/linker flags. * Fix condition for determining default for DISABLE_LTO. * Turn off LTO auto-detection in RPM package builds. On pretty much all RPM platforms, the RPM build process itself will correctly add the required compiler flags when building, so we don’t actually need to auto-detect LTO support in CMake here. Additionally, on at least some RPM platforms, CMake’s auto-detection for LTO support actually breaks the build when used. * Disable function and data sections when using LTO. On at least some systems, `-fdata-sections` combined with LTO reliably causes failures at link time with our code. The final binary size on systems where the combination _works_ differs by no more than a few KiB on average (tested on 64-bit x86 on Ubuntu 22.04, Debian 12, Fedora 39, and Rocky Linux 9), so we’re not actually getting almost any benefit out of using both with things as they are now, but LTO gives us a meaasurable performance improvement that per-function and per-data sections do not. * Restructure in-line with current repo state. * Disable LTO on Windows builds since it doesn’t work there. * Fix compiler flag handling order. * Switch LTO option name to USE_LTO for consistency with USE_MOLD.
Co-authored-by: ilyam8 <[email protected]>
Co-authored-by: ilyam8 <[email protected]>
Reviewer's Guide by SourceryThis pull request introduces several new metrics for monitoring Active Directory and .NET Framework performance, enhancing the visibility of these critical Windows services. It also includes changes to the build system to ensure that the code is compiled with the required flags. Class diagram for Windows Plugin ModulesclassDiagram
class proc_module {
+char* name
+char* dim
+int enabled
+int (*func)(int update_every, usec_t dt)
}
class win_modules {
+GetSystemUptime
+GetSystemRAM
+PerflibProcesses
+PerflibProcessor
+PerflibMemory
+PerflibStorage
+PerflibNetwork
+PerflibObjects
+PerflibHyperV
+PerflibThermalZone
+PerflibWebService
+PerflibMSSQL
+PerflibNetFramework
+PerflibAD
+PerflibADCS
}
win_modules --> proc_module : contains[]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Refactor code formatting in
perflib-ad.c,perflib-netframework.c,windows_plugin.c, and add support for Active Directory Certificate Services (ADCS) metrics collection inperflib-adcs.c. Updatemetadata.yamlto include the new ADCS metrics.New Features:
Enhancements:
perflib-ad.c,perflib-netframework.c, andwindows_plugin.cusing clang-format to improve readability and maintainability.Tests: