[pull] master from netdata:master

[pull]

See Commits and Changes for more details.

---

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Add a breadcrumb to Sentry before aborting on failure and fix a typo in a health check message. Remove fluentbit log symlink.

New Features:

• New Feature: Add a function to add breadcrumbs to Sentry

Bug Fixes:

• Fix: ClickHouse replicated tables are read-only due to startup without ZooKeeper configured or ZooKeeper session loss

Enhancements:

• Enhancement: Add a breadcrumb with the action data to Sentry before aborting

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new breadcrumb mechanism into the Sentry integration and refines error logging and configuration messages. The changes add functionality for recording additional context when errors occur, improve messaging in monitoring configurations, and clean up obsolete log redirections in the Docker setup.

Sequence Diagram for Sentry Breadcrumb Logging

sequenceDiagram
    participant DS as Daemon Shutdown
    participant SB as nd_sentry_add_breadcrumb()
    participant ST as sentry_telemetry_disabled()
    participant CB as sentry_value_new_breadcrumb()
    participant SA as sentry_add_breadcrumb()

    DS->>SB: nd_sentry_add_breadcrumb(action_data)
    SB->>ST: sentry_telemetry_disabled()
    alt Telemetry Disabled
        SB-->>DS: Return (breadcrumb not added)
    else Telemetry Enabled
        SB->>CB: Create breadcrumb with "fatal" and message
        CB-->>SB: Return breadcrumb object
        SB->>SA: Add breadcrumb
        SA-->>SB: Breadcrumb added
    end
    DS->>DS: abort() [if error condition persists]

Loading

File-Level Changes

Change	Details	Files
Added breadcrumb functionality to the Sentry integration.	Implemented a new function to add breadcrumbs when receiving a message, with a check for telemetry being disabled. Added the corresponding function prototype in the header file.	src/daemon/sentry-native/sentry-native.c src/daemon/sentry-native/sentry-native.h
Enhanced daemon shutdown error handling to include breadcrumbs.	Modified the error-handling branch in the shutdown process to record additional context via the new breadcrumb function if action data is available.	src/daemon/daemon-shutdown.c
Updated configuration messaging for ClickHouse health monitoring.	Reworded the informational message in the ClickHouse configuration file to improve clarity.	src/health/health.d/clickhouse.conf
Cleaned up Docker logging configuration.	Removed the redundant symlink for fluentbit.log in the Dockerfile.	packaging/docker/Dockerfile

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.