Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from netdata:master #375

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 19, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

The pull request improves EPEL support on RHEL-based systems by enabling the CodeReady Builder repository and ensuring EPEL is correctly installed.

Bug Fixes:

  • The installer now correctly installs EPEL on RHEL systems.

Enhancements:

  • On RHEL-based systems, the installer now attempts to enable the CodeReady Builder repository to satisfy EPEL dependencies.

- On all RHEL versions, correctly pull the EPEL release package from
  the Fedora project, since RHEL does not include it in their repos.
- On RHEL 9 and newer, as well as clones, enable the CodeReady Builder
  repo, which is apparently required there to make EPEL work at all,
  before installing EPEL.
@pull pull bot added the ⤵️ pull label Feb 19, 2025
@pull pull bot merged commit 1786e91 into webfutureiorepo:master Feb 19, 2025
Copy link

sourcery-ai bot commented Feb 19, 2025

Reviewer's Guide by Sourcery

The installer now handles EPEL dependencies on RHEL-based systems (version 9 or greater) by enabling the CodeReady Builder repository. Additionally, the installer attempts to directly install the epel-release package from a URL when the distro is RHEL.

Sequence diagram for EPEL installation on RHEL 9+

sequenceDiagram
  participant Installer
  participant System

  Installer->>System: Check if RHEL 9+ and EPEL required
  System-->>Installer: Yes
  Installer->>System: Enable CodeReady Builder repo
  System-->>Installer: Repo enabled
  Installer->>System: Install EPEL package from URL
  alt Installation successful
    System-->>Installer: EPEL installed
  else Installation failed
    System-->>Installer: Error
    Installer->>Installer: Warning: Failed to install EPEL
  end
Loading

File-Level Changes

Change Details Files
The installer now attempts to enable the CodeReady Builder repository on RHEL-based systems (version 9 or greater) to satisfy EPEL dependencies.
  • Added logic to enable the CodeReady Builder repository when the system is RHEL-based and the version is 9 or greater.
  • The CodeReady Builder repository is enabled using subscription-manager on RHEL and dnf config-manager on other distributions.
  • When the distro is RHEL, the installer attempts to install the epel-release package directly from a URL.
  • The installation of EPEL is skipped if the distro is RHEL.
packaging/installer/kickstart.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant