Add lending archiving#4114
Open
Bestem0r wants to merge 1 commit into
Open
Conversation
4 tasks
ch0rizo
requested changes
Apr 16, 2026
ch0rizo
left a comment
ch0rizo
left a comment
Contributor
There was a problem hiding this comment.
Anyone who can PATCH can archive any request. The archived field is added directly to LendingRequestCreateAndUpdateSerializer without any permission guard. The existing validate() method only checks permissions on status changes - it doesn't restrict who can set archived. This means:
- An admin/responsible person could archive a requester's request.
- The requester could archive someone else's request if they somehow get access
ch0rizo
requested changes
Apr 16, 2026
| self.instance, "lendable_object", None | ||
| ) | ||
| user = self.context["request"].user | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| if "archived" in attrs and self.instance: | |
| if self.instance.created_by != user: | |
| raise serializers.ValidationError( | |
| {"archived": "You can only archive your own requests."} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds archiving of lending requests to clear up inbox.
Frontend PR.
Result
Screencast.From.2026-04-13.22-23-36.mp4
Testing