Content: The input of triangular should be at least 2D tensor #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh this is great - had it on my queue for a while but haven't popped it 😢. Thanks Joshua. 👏 |
fdwr
approved these changes
Feb 1, 2024
inexorabletash
force-pushed
the
content-triangular-atleast2d
branch
from
5a7ae65 to
d7b96b2
Compare
inexorabletash
force-pushed
the
content-triangular-atleast2d
branch
from
d7b96b2 to
9f7f739
Compare
inexorabletash
force-pushed
the
content-triangular-atleast2d
branch
from
9f7f739 to
3cef040
Compare
Bruce is on vacation for Chinese New Year two weeks, but I think he'd be content to merge it as he originally opened the issue on behalf of my comment anyway while reviewing his tests, and Ningxin reviewed it already. |
|
@fdwr please feel free to merge and we’ll check the GH permission knobs are properly set for you at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494 which has the text and example. I added the validation step which matches the webnn-baseline impl referenced therein.
Preview | Diff