Remove MLBufferResourceView #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
a-sully
commented
Feb 4, 2024
huningxin
reviewed
Feb 5, 2024
a-sully
force-pushed
the
remove-MLBufferResourceView
branch
from
cb317f1 to
0115dcf
Compare
Follow-up to webmachinelearning#546. MLBufferResourceView is not relevant without MLCommandEncoder
a-sully
force-pushed
the
remove-MLBufferResourceView
branch
from
0115dcf to
66588cf
Compare
a-sully
added a commit
to a-sully/webnn
that referenced
this pull request
Feb 8, 2024
Follow-up to webmachinelearning#553 Fixes webmachinelearning#560
|
#546 just merged! I don't have write access to the repo, so I can't merge this PR. Once @bbernhar gives approval, @huningxin (or someone else with write access) please feel free to merge this. Thank you! |
|
Thanks, @a-sully LGTM too. |
|
Thank you @bbernhar and @huningxin for the reviews! I have a follow-up queued up to remove Friendly ping to someone with write access to please merge this PR when you get the chance. Thank you! |
|
Thanks @a-sully for this contribution! Reviewed by @huningxin @bbernhar. |
github-actions bot
added a commit
that referenced
this pull request
Feb 15, 2024
SHA: 1fddf79 Reason: push, by anssiko Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
a-sully
added a commit
to a-sully/webnn
that referenced
this pull request
Feb 15, 2024
Follow-up to webmachinelearning#553 Fixes webmachinelearning#560
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #546.
MLBufferResourceViewis not relevant withoutMLCommandEncoderPreview | Diff