Skip to content

Remove MLBufferView #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Remove MLBufferView #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ When the {{MLContext/[[contextType]]}} is set to [=context type/default=] with t

<details open algorithm>
<summary>
To <dfn>validate buffer with descriptor</dfn> given {{MLBufferView}} |bufferView| and {{MLOperandDescriptor}} |descriptor|, run the following steps:
To <dfn>validate buffer with descriptor</dfn> given {{ArrayBufferView}} |bufferView| and {{MLOperandDescriptor}} |descriptor|, run the following steps:
</summary>
<div class=algorithm-steps>
1. If |bufferView|'s [=element type=] does not match to |descriptor|.{{MLOperandDescriptor/dataType}} according to [this table](#appendices-mloperanddatatype-arraybufferview-compatibility), return false.
Expand Down Expand Up @@ -1123,8 +1123,6 @@ The {{MLGraphBuilder}} interface defines a set of operations as identified by th
<script type=idl>
typedef record<DOMString, MLOperand> MLNamedOperands;

typedef ArrayBufferView MLBufferView;

[SecureContext, Exposed=(Window, DedicatedWorker)]
interface MLGraphBuilder {
// Construct the graph builder from the context.
Expand All @@ -1134,7 +1132,7 @@ interface MLGraphBuilder {
MLOperand input(DOMString name, MLOperandDescriptor descriptor);

// Create an operand for a graph constant.
MLOperand constant(MLOperandDescriptor descriptor, MLBufferView bufferView);
MLOperand constant(MLOperandDescriptor descriptor, ArrayBufferView bufferView);

// Create a single-value operand from the specified number of the specified type.
MLOperand constant(double value, optional MLOperandDataType type = "float32");
Expand Down Expand Up @@ -1592,7 +1590,7 @@ Create a constant {{MLOperand}} of the specified data type and shape that contai
<div>
**Arguments:**
- *descriptor*: an {{MLOperandDescriptor}}. The descriptor of the output tensor.
- *bufferView*: an {{MLBufferView}}. The view of the buffer containing the initializing data.
- *bufferView*: an {{ArrayBufferView}}. The view of the buffer containing the initializing data.
**Returns:**: an {{MLOperand}}. The constant output tensor.
</div>

Expand Down