Skip to content

Feat: added defaults functions for clean-css and csso #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2021

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Fixes #50
Fixes #62

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #76 (8184447) into master (8ebb052) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   99.49%   99.50%           
=======================================
  Files           3        3           
  Lines         198      200    +2     
  Branches       67       67           
=======================================
+ Hits          197      199    +2     
  Misses          1        1           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebb052...8184447. Read the comment docs.

@alexander-akait alexander-akait merged commit 5211eed into master Mar 23, 2021
@alexander-akait alexander-akait deleted the feat-csso-cleancss branch March 23, 2021 16:36
@RDIL
Copy link
Contributor

RDIL commented Mar 23, 2021

Cheers!

@slorber
Copy link

slorber commented Mar 24, 2021

Thanks!

So the multiple minifiers array syntax was already supported as I understand right?

@alexander-akait
Copy link
Member

No, it will be in v2 (release soon)

@slorber
Copy link

slorber commented Mar 25, 2021

I see thanks, looks the array syntax is not released yet (#72)

release soon

No hurry, just wondering what you mean by soon? 1 day / 1 week / 1 month?

@alexander-akait
Copy link
Member

Hope this week

@alexander-akait
Copy link
Member

We need review #78 and merge, after this we can do release, but I have very limited time 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working with 2 minimizers Set appropriate defaults for clean-css and csso
4 participants