-
-
Notifications
You must be signed in to change notification settings - Fork 384
Add documentation in README.md about how to extract all CSS in one file #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation in README.md about how to extract all CSS in one file #60
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
====================================
Coverage 0% 0%
====================================
Files 3 3
Lines 157 157
Branches 32 32
====================================
Misses 125 125
Partials 32 32 Continue to review full report at Codecov.
|
}, | ||
plugins: [ | ||
new MiniCssExtractPlugin({ | ||
filename: "[name].css", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add [contenthash]
template to avoid problem with cache who use this configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you, [hash]
could also help with the cache, or the hash: true
option on HtmlWebpackPlugin
if you're using it. I guess it depends on your project setup.
Not quite sure this documentation section is about cache burst though, hence not adding it in the example configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks!
Following discussions on the issues, this PR aims at documenting the common use-case of extracting all CSS in one file, similar to what https://github.com/webpack-contrib/extract-text-webpack-plugin does.
Tested in a small project there: https://github.com/Akkenar/CSS-Single-File-Example