test(Proxy): skip Proxy.test.js #1667
Conversation
This test is unstable when running on Node v11 on MacOS.
hiroppy
requested review from
alexander-akait and
michael-ciniawsky
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1667 +/- ##
==========================================
+ Coverage 75.08% 75.37% +0.29%
==========================================
Files 18 19 +1
Lines 590 597 +7
Branches 171 172 +1
==========================================
+ Hits 443 450 +7
Misses 113 113
Partials 34 34
Continue to review full report at Codecov.
|
| // issue: https://github.com/webpack/webpack-dev-server/pull/1633#issuecomment-463938675 | ||
| if (shouldSkipTestSuite()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
All tests failed? Maybe we can skip only one test?
There was a problem hiding this comment.
As far as I confirm, running two tests seems to fail.
There was a problem hiding this comment.
@hiroppy can we ship only their? thanks
There was a problem hiding this comment.
The first test(anyone) will succeed but subsequent tests will fail.
Probably postprocessing would be a problem.
Once we merge this PR and then I think that it is better to investigate the cause separately.(maybe difficult)
This test is unstable when running on Node v11 on MacOS.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
see #1633 (comment)
Breaking Changes
no
Additional Info
HistoryApiFallback.test.jsseems to be good when we add skipping code toProxy.test.js.