Skip to content

Comments

Allow replaying WACZ files from replica storage#2436

Closed
ikreymer wants to merge 3 commits intomainfrom
replay-from-replica
Closed

Allow replaying WACZ files from replica storage#2436
ikreymer wants to merge 3 commits intomainfrom
replay-from-replica

Conversation

@ikreymer
Copy link
Member

@ikreymer ikreymer commented Feb 27, 2025

Add replay_from_replica helm chart value, which, if set, will use the first replica (when available) for replay instead of the primary storage.

@ikreymer ikreymer requested a review from tw4l February 27, 2025 20:04
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and tested as working. Could be nice to eventually be able to choose which replica is used by name but I think first in list is fine for now.

@ikreymer ikreymer marked this pull request as draft March 1, 2025 20:24
@ikreymer
Copy link
Member Author

ikreymer commented Mar 1, 2025

Perhaps we want to enable this per-org, rather than per-cluster? The need for this has diminished, since we've figured out a major issue in our slowdown was the CDN on DO.

@tw4l
Copy link
Member

tw4l commented Mar 3, 2025

Perhaps we want to enable this per-org, rather than per-cluster? The need for this has diminished, since we've figured out a major issue in our slowdown was the CDN on DO.

It's a good point that custom org storages might change this significantly, since we'll have more complexity of which storage is used per-org. Maybe better to hold off until we have a concrete need?

@ikreymer
Copy link
Member Author

ikreymer commented Mar 3, 2025

Closing for now, let's come back after #578

@ikreymer ikreymer closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants