Standardize POST canonicalization query strings with pywb #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of bringing consistency between pywb and warcio.js with regard to how query parameters are constructed from request bodies for non-GET requests. The more complicated test is duplicated in pywb to help ensure that the results are consistent across our toolsets/langauges.
tw4l
changed the title
|
Tested with fuzzy matching, the keys are more accurate now, so should only help with fuzzy matching in wabac.js! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
This PR modifies canonicalization of non-GET request bodies into query strings to be consistent across Webrecorder projects. It introduces a new test case that is also in pywb to help ensure parity.
This is part of a cross-repo effort to standardize how POST canonicalization works in Webrecorder tools, and document this in a Webrecorder specfiication.
Todo
Still needs testing against fuzzy matching to ensure that there aren't unintended side effects to the change.