AVAudioEngine version AudioDeviceModule #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Fix adm selection Fixes Revert adm selection in audio_device_impl Rename IsManualRenderingMode Simplify pcm buffer delegate Fixes Fixes Ducking config Strip manual rendering logic Runtime-ducking config Fix compile Fix start recording Connect output Buffer logic Enable output when input is enabled
Pre initialize mode Pre initialize logic Persistent Checks Fix buffer logic Patch default input_mute state Buffer checks Start buffer on enable Delay estimate 0 Stop engine on interrupt Pass should_resume Silence warning Correct session config Fix state Start logic Misc Rem ses Rem ses2 State helper Minor patch Simplify Change stop create order Working state Ref State helpers
Re-wire manual audio input bypass & agc Mac aec off by default AudioOptions initially false Engine reconfigure AGC & AEC available Mac device Fix build
hiroshihorie
added a commit
to livekit/client-sdk-swift
that referenced
this pull request
Jan 30, 2025
Using lib from webrtc-sdk/webrtc#158. macOS will still use previous implementation at the moment. (Device selection etc not implemented yet) ### New features [Advanced other audio ducking](https://developer.apple.com/videos/play/wwdc2023/10235/?time=199) Lower audio from other apps dynamically when voice activity is detected. [Muted talker detection](https://developer.apple.com/videos/play/wwdc2023/10235/?time=475) Detect voice activity even mic is off after calling `AudioManager.shared.prepareRecording()`. Provide custom AVAudioNode configuration for input and output through `onEngineWillConnectInput` and `onEngineWillConnectOutput` handlers. Early recording initialization with `AudioManager.shared.prepareRecording()` without mic indicator turning on. Early mic input buffer capturing with `AudioManager.shared.startLocalRecording()` without the need for Room and connection. ### Improvements Correct mic muting logic without the requirement of restarting whole audio unit (previous implementation). Correct audio session configuration timing. AudioDeviceModule requests configuration when it's required, instead of counting tracks and configuring it in advance (previous implementation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS support included:
AVAudioEngineConfigurationChangeNotification.